starred/1Remote

Fork 0

mirror of https://github.com/1Remote/1Remote.git synced 2026-04-25 13:36:03 +03:00

[GH-ISSUE #788] RequestRatingView does not open with "Exit" #2564

New issue

Closed

opened 2026-03-01 17:21:32 +03:00 by kerem · 4 comments

kerem commented

2026-03-01 17:21:32 +03:00

Owner

Originally created by @itagagaki on GitHub (Nov 29, 2024).
Original GitHub issue: https://github.com/1Remote/1Remote/issues/788

Originally assigned to: @VShawn on GitHub.

When the user clicks the X button in the main window, the RequestRatingView window will appear if the conditions are met.
However, if the user exits the application with “Exit” from the window or icon menu, it will not appear.
It would be better if the same process was done on each path that exits the application.

Originally created by @itagagaki on GitHub (Nov 29, 2024). Original GitHub issue: https://github.com/1Remote/1Remote/issues/788 Originally assigned to: @VShawn on GitHub. When the user clicks the X button in the main window, the `RequestRatingView` window will appear if the conditions are met. However, if the user exits the application with “Exit” from the window or icon menu, it will not appear. It would be better if the same process was done on each path that exits the application.

kerem

2026-03-01 17:21:32 +03:00

closed this issue
added the
meta-enhancement
label

kerem commented

2026-03-01 17:21:33 +03:00

Author

Owner

@itagagaki commented on GitHub (Nov 29, 2024):

Ah, so the X button simply closes the main window, but does not terminate the process (the other windows remain), and "Exit" terminates the process. I hesitate if users will understand this difference.

@itagagaki commented on GitHub (Nov 29, 2024): Ah, so the X button simply closes the main window, but does not terminate the process (the other windows remain), and "Exit" terminates the process. I hesitate if users will understand this difference.

kerem commented

2026-03-01 17:21:33 +03:00

Author

Owner

@VShawn commented on GitHub (Nov 30, 2024):

Ah, so the X button simply closes the main window, but does not terminate the process (the other windows remain), and "Exit" terminates the process. I hesitate if users will understand this difference.

That's right, it's exactly as you said. And most users can understand that clicking X button will minimiz to the system tray.

A better approach is to provide an animation to show the procedure minimizes to the tray after clicking the close button, just like in macOS. However, I don't know how to implement this animation in WPF.

@VShawn commented on GitHub (Nov 30, 2024): > Ah, so the X button simply closes the main window, but does not terminate the process (the other windows remain), and "Exit" terminates the process. I hesitate if users will understand this difference. That's right, it's exactly as you said. And most users can understand that clicking X button will minimiz to the system tray. A better approach is to provide an animation to show the procedure `minimizes to the tray` after clicking the close button, just like in macOS. However, I don't know how to implement this animation in WPF.

kerem commented

2026-03-01 17:21:33 +03:00

Author

Owner

@itagagaki commented on GitHub (Dec 3, 2024):

Yeah, it would certainly be easier to understand if it could be done like macOS, but that's not possible to do that with other apps, so it's not an option.

At the moment, the only trigger to bring up a dialog is the Close button, but if you think that is sufficient, that is fine.

@itagagaki commented on GitHub (Dec 3, 2024): Yeah, it would certainly be easier to understand if it could be done like macOS, but that's not possible to do that with other apps, so it's not an option. At the moment, the only trigger to bring up a dialog is the Close button, but if you think that is sufficient, that is fine.

kerem commented

2026-03-01 17:21:33 +03:00

Author

Owner

@VShawn commented on GitHub (Dec 4, 2024):

Yes, I think one entrypoint is enough, especially I don't want RequestRatingView to bother users too much.

@VShawn commented on GitHub (Dec 4, 2024): Yes, I think one entrypoint is enough, especially I don't want RequestRatingView to bother users too much.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/1Remote#2564

No description provided.

Rows
Columns