[GH-ISSUE #173] Multiple tag search #2065

Closed
opened 2026-03-01 17:17:21 +03:00 by kerem · 12 comments
Owner

Originally created by @majkinetor on GitHub (Dec 16, 2021).
Original GitHub issue: https://github.com/1Remote/1Remote/issues/173

Originally assigned to: @VShawn on GitHub.

Is your feature request related to a problem? Please describe.

Currently its not possible to show connections having multiple tags.

Describe the solution you'd like

Lets use #xyz phrase in search to create AND query. For example #personal #server would shows connections tagged both with personal AND server. Negative tags should also be supported - -#personal for example to find connections NOT containing that tag.

Describe alternatives you've considered

There are no alternatives

Additional context
There could be sugar behavior later when this is implmented:

  1. Click on tag replaces current search (we basically have this now)
  2. CTRL click on tag adds it in search
  3. (CTRL) right click on tag adds negative search (i.e. #server -#personal would show connections having server tag but not having personal tag)
  4. Middle click on tag to show popup via which you can rename it or delete it (there could be more options, such as tag color and tag description but those are not that important).

With this there is only one IMO mandatory option that we need to have for efficient tag based workflow - adding or removing tags from group of connections (not just replacing all the tags as we have today).

Originally created by @majkinetor on GitHub (Dec 16, 2021). Original GitHub issue: https://github.com/1Remote/1Remote/issues/173 Originally assigned to: @VShawn on GitHub. **Is your feature request related to a problem? Please describe.** Currently its not possible to show connections having multiple tags. **Describe the solution you'd like** Lets use `#xyz` phrase in search to create AND query. For example `#personal #server` would shows connections tagged both with personal AND server. Negative tags should also be supported - `-#personal` for example to find connections NOT containing that tag. **Describe alternatives you've considered** There are no alternatives **Additional context** There could be sugar behavior later when this is implmented: 0. Click on tag replaces current search (we basically have this now) 1. CTRL click on tag adds it in search 2. (CTRL) right click on tag adds negative search (i.e. `#server -#personal` would show connections having `server` tag but not having `personal` tag) 3. Middle click on tag to show popup via which you can rename it or delete it (there could be more options, such as tag color and tag description but those are not that important). With this there is only one IMO mandatory option that we need to have for efficient tag based workflow - adding or removing tags from group of connections (not just replacing all the tags as we have today).
Author
Owner

@VShawn commented on GitHub (Dec 16, 2021):

how this work in the launcher?

<!-- gh-comment-id:995790706 --> @VShawn commented on GitHub (Dec 16, 2021): how this work in the launcher?
Author
Owner

@majkinetor commented on GitHub (Jan 15, 2022):

It could work exactly the same. Launcher search or list search, it shouldn't matter.

So:

  1. #database #project1 - find all connections containing both tags
  2. #database -#project1 - find all databases less those of project1
  3. #project1 foo - find all connections containing project1 tag and among them, find those having foo somewhere (name, computer name, even tags with option to search within them enabled)
<!-- gh-comment-id:1013682712 --> @majkinetor commented on GitHub (Jan 15, 2022): It could work exactly the same. Launcher search or list search, it shouldn't matter. So: 1. `#database #project1` - find all connections containing both tags 2. `#database -#project1` - find all databases less those of project1 3. `#project1 foo` - find all connections containing project1 tag and among them, find those having `foo` somewhere (name, computer name, even tags with option to search within them enabled)
Author
Owner

@VShawn commented on GitHub (Jan 21, 2022):

done the job.

image

image

<!-- gh-comment-id:1018065259 --> @VShawn commented on GitHub (Jan 21, 2022): done the job. ![image](https://user-images.githubusercontent.com/10143738/150446459-e159c07d-1624-4d00-919c-44418e51f47a.png) ![image](https://user-images.githubusercontent.com/10143738/150446544-505f04cf-51f3-4862-b490-8517d0bf9340.png)
Author
Owner

@majkinetor commented on GitHub (Jan 21, 2022):

Awesome.

But, wait, why are you showing # in front of every tag on display? Its just marker for search type, it shouldn't propagate to tag name. It just adds noise IMO.

<!-- gh-comment-id:1018749705 --> @majkinetor commented on GitHub (Jan 21, 2022): Awesome. But, wait, why are you showing # in front of every tag on display? Its just marker for search type, it shouldn't propagate to tag name. It just adds noise IMO.
Author
Owner

@VShawn commented on GitHub (Jan 23, 2022):

in the launcher, PRM enter the TAG matching logic through the # prefix. In order to keep all TAG display formats, all the tags were added a # prefix.

<!-- gh-comment-id:1019439374 --> @VShawn commented on GitHub (Jan 23, 2022): in the launcher, PRM enter the TAG matching logic through the `#` prefix. In order to keep all TAG display formats, all the tags were added a `#` prefix.
Author
Owner

@majkinetor commented on GitHub (Jan 23, 2022):

Well ok, I think it just adds noise here since there are dedicated tag locations in PRM. When there is no dedicated location then it makes sense (e.g Twitter allows tags among narrative so it must have #).

<!-- gh-comment-id:1019439923 --> @majkinetor commented on GitHub (Jan 23, 2022): Well ok, I think it just adds noise here since there are dedicated tag locations in PRM. When there is no dedicated location then it makes sense (e.g Twitter allows tags among narrative so it must have #).
Author
Owner

@majkinetor commented on GitHub (Jan 26, 2022):

We don't have multiple tag search in list view:

image

image

<!-- gh-comment-id:1022132977 --> @majkinetor commented on GitHub (Jan 26, 2022): We don't have multiple tag search in list view: ![image](https://user-images.githubusercontent.com/85767/151159379-76f5680a-0be4-40a0-ac07-57d0f65368d3.png) ![image](https://user-images.githubusercontent.com/85767/151159389-024bb4d0-d894-4c2d-bb1e-9f73a859b83a.png)
Author
Owner

@majkinetor commented on GitHub (Feb 23, 2022):

I will reopen this due to it not working in the list view.

<!-- gh-comment-id:1049088034 --> @majkinetor commented on GitHub (Feb 23, 2022): I will reopen this due to it not working in the list view.
Author
Owner

@VShawn commented on GitHub (Feb 26, 2022):

I have done this tick.

Since huge code changed for the ticket, there must some bugs in it.

I will test it for a week before I publish it.

feel free to reopen this ticket if anyone find a bug (please do remember backup your database)

0.6.2.beta2.zip

<!-- gh-comment-id:1051893360 --> @VShawn commented on GitHub (Feb 26, 2022): I have done this tick. Since huge code changed for the ticket, there must some bugs in it. I will test it for a week before I publish it. feel free to reopen this ticket if anyone find a bug (please do remember backup your database) [0.6.2.beta2.zip](https://github.com/VShawn/PRemoteM/files/8146292/0.6.2.beta2.zip)
Author
Owner

@majkinetor commented on GitHub (Feb 26, 2022):

Great. I will start using it and report anything I find here.

<!-- gh-comment-id:1052117610 --> @majkinetor commented on GitHub (Feb 26, 2022): Great. I will start using it and report anything I find here.
Author
Owner

@majkinetor commented on GitHub (Feb 26, 2022):

FYI, existing database is deleted with this 0.6.2.beta2.zip

<!-- gh-comment-id:1052636999 --> @majkinetor commented on GitHub (Feb 26, 2022): FYI, existing database is deleted with this 0.6.2.beta2.zip
Author
Owner

@majkinetor commented on GitHub (Feb 26, 2022):

Sorry, its not deleted, it is set to C:\FastToolsShared\PRemoteM\PRemoteM.db :)

<!-- gh-comment-id:1052638815 --> @majkinetor commented on GitHub (Feb 26, 2022): Sorry, its not deleted, it is set to `C:\FastToolsShared\PRemoteM\PRemoteM.db` :)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/1Remote#2065
No description provided.