mirror of
https://github.com/1Remote/1Remote.git
synced 2026-04-25 13:36:03 +03:00
[GH-ISSUE #102] Pin and lock button for tab window #2005
Labels
No labels
area-configuration
area-ct-app
area-ct-rdp
area-ct-remoteapp
area-ct-ssh
area-ct-vnc
area-launcher
area-list
area-tags
area-teamwork
bug
chore
dependencies
general-build/ci
general-performance
general-refactor
general-security
general-supportive
general-ux
meta-documentation
meta-enhancement
meta-enhancement
meta-feature
meta-help-wanted
meta-unknown-error
priority-hi
priority-low
pull-request
question
resolution-duplicate
resolution-invalid
resolution-wontfix
stale
task-put-off
task-still-considering
task-working-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/1Remote#2005
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @VShawn on GitHub (Mar 30, 2021).
Original GitHub issue: https://github.com/1Remote/1Remote/issues/102
Originally assigned to: @VShawn on GitHub.
Is it necessary to add pin button on the tab window?
It can:
@VShawn commented on GitHub (Mar 30, 2021):
relate to https://github.com/mRemoteNG/mRemoteNG/issues/1947
@majkinetor commented on GitHub (Mar 30, 2021):
How do you plan to do this if window contain multiple tabs? This then, I assume, works on entire window, not on connection ? You said RD but you surely think ANY connection ?
I doubt those 2 things should be under the same option - drag-&-resize has nothing to do with always-on-top feature.
For one, in any app pin is related to active tab and depending on app it does one of the following things:
I think there is a merit to prevent accidental closing - It happened to me numerious times to accidently want to close app inside the RDP and I close entire PRM window instead, and this option could prevent that. Additionally, it could move tabs to special location and color them differently (for instance all the way left, or all the way right). Now, when using close action on pinned tab, there should be popup: _You are trying to close pinned connection, are you sure? _
Regarding always on top, it could be one of the actions in tab right click if it should work on connections, or new icon in taskbar, if it should work on entire window (that can hold multiple connections in tab). I think later option is more intuitive and it doesn't prevent you to drag specific tab out in order to put always-on-top on it alone.
Resizig prevention should IMO be separated. Perhaps that icon could be a menu of check boxes:
@VShawn commented on GitHub (Mar 30, 2021):
when tab window is pinned, tabs can still be dragged and detach, pinned status will not be inherited by the new tab window.
I dont like a menu, I can't read the window pin status since a menu is alway close. I‘d like to add a lock button to disable resize and close.
Me too, several times click the tab close button by mistake