[PR #843] [MERGED] Fix ShowFolder's anomaly handling (Fix #841) #1865

New issue

Closed

opened 2026-02-28 12:07:01 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 12:07:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/1Remote/1Remote/pull/843
Author: @itagagaki
Created: 1/26/2025
Status: ✅ Merged
Merged: 1/26/2025
Merged by: @VShawn

Base: main ← Head: fix-ShowFolder-anomaly-handling

📝 Commits (1)

ca3769c Fix ShowFolder's anomaly handling

📊 Changes

2 files changed (+52 additions, -35 deletions)

View changed files

📝 Ui/Model/Protocol/FileTransmit/Transmitters/TransmitterFtp.cs (+7 -0)
📝 Ui/View/Host/ProtocolHosts/VmFileTransmitHost.cs (+45 -35)

📄 Description

This fixes #841

Update the remote item view only when the items are successfully retrieved. When an exception is caught, do not make any changes.
Since it is not possible to distinguish between cases where the referenced directory does not exist and cases where the contents of the referenced directory are empty, check the existence of the directory before retrieving the item list, and display an error if it does not exist.
Add code to throw an exception if FTP connect fails.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/1Remote/1Remote/pull/843 **Author:** [@itagagaki](https://github.com/itagagaki) **Created:** 1/26/2025 **Status:** ✅ Merged **Merged:** 1/26/2025 **Merged by:** [@VShawn](https://github.com/VShawn) **Base:** `main` ← **Head:** `fix-ShowFolder-anomaly-handling` --- ### 📝 Commits (1) - [`ca3769c`](https://github.com/1Remote/1Remote/commit/ca3769cd82cc5489637f50ccabd73b2b5670c4c5) Fix ShowFolder's anomaly handling ### 📊 Changes **2 files changed** (+52 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `Ui/Model/Protocol/FileTransmit/Transmitters/TransmitterFtp.cs` (+7 -0) 📝 `Ui/View/Host/ProtocolHosts/VmFileTransmitHost.cs` (+45 -35) </details> ### 📄 Description This fixes #841 - Update the remote item view only when the items are successfully retrieved. When an exception is caught, do not make any changes. - Since it is not possible to distinguish between cases where the referenced directory does not exist and cases where the contents of the referenced directory are empty, check the existence of the directory before retrieving the item list, and display an error if it does not exist. - Add code to throw an exception if FTP connect fails. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-28 12:07:01 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/1Remote#1865

No description provided.

Rows
Columns