[PR #531] [MERGED] App portocol remake #1840

New issue

Closed

opened 2026-02-28 12:06:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 12:06:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/1Remote/1Remote/pull/531
Author: @VShawn
Created: 10/16/2023
Status: ✅ Merged
Merged: 10/17/2023
Merged by: @VShawn

Base: main ← Head: app_portocol_remake

📝 Commits (10+)

f1d8ee0 [WIP] redesign app protocol model
2e88434 [WIP] redesign App Argument model.
834b2df [WIP] redesign App Argument model.
7667391 [WIP] new App view first edition(not done yet)
44c36ef [WIP] new App add selections
00dd995 [WIP] Editor for app arguments
e455766 [WIP] Editor for app arguments
4f43f3d [WIP] app arguments edit & refacing
2beb103 [WIP] app argument's Selections change to Dictionary, add preset configurations for kitty
86d7ca2 [WIP] app argument supports arguments with no blank(fro winscp cli)

📊 Changes

88 files changed (+3563 additions, -515 deletions)

View changed files

📝 Shawn.Utils (+1 -1)
📝 Ui/Controls/AutoCompleteComboBox.xaml.cs (+1 -1)
📝 Ui/Controls/LogoSelector.xaml.cs (+1 -1)
📝 Ui/Controls/PasswordInput.xaml (+5 -5)
📝 Ui/Controls/PasswordInput.xaml.cs (+3 -2)
📝 Ui/Ioc.cs (+23 -2)
📝 Ui/Model/GlobalData.cs (+28 -23)
➕ Ui/Model/Protocol/AppArgument.cs (+396 -0)
➕ Ui/Model/Protocol/AppArgumentHelper.cs (+541 -0)
➕ Ui/Model/Protocol/AppProtocol.cs (+179 -0)
📝 Ui/Model/Protocol/Base/Credential.cs (+8 -5)
📝 Ui/Model/Protocol/Base/ProtocolBase.cs (+21 -6)
📝 Ui/Model/Protocol/Base/ProtocolBaseWithAddressPort.cs (+21 -3)
📝 Ui/Model/Protocol/Base/ProtocolBaseWithAddressPortUserPwd.cs (+38 -3)
➖ Ui/Model/Protocol/LocalApp.cs (+0 -179)
📝 Ui/Model/Protocol/SFTP.cs (+15 -9)
📝 Ui/Model/Protocol/SSH.cs (+17 -9)
📝 Ui/Model/Protocol/Vnc.cs (+15 -0)
📝 Ui/Model/ProtocolActionHelper.cs (+10 -10)
📝 Ui/Model/TagActionHelper.cs (+9 -9)

...and 68 more files

📄 Description

remake the app protocol

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/1Remote/1Remote/pull/531 **Author:** [@VShawn](https://github.com/VShawn) **Created:** 10/16/2023 **Status:** ✅ Merged **Merged:** 10/17/2023 **Merged by:** [@VShawn](https://github.com/VShawn) **Base:** `main` ← **Head:** `app_portocol_remake` --- ### 📝 Commits (10+) - [`f1d8ee0`](https://github.com/1Remote/1Remote/commit/f1d8ee0257fb64293afc4c1aef200cb02d9d106d) [WIP] redesign app protocol model - [`2e88434`](https://github.com/1Remote/1Remote/commit/2e88434c7ab62df92e0ae9b3c18c3e9a422f8cc7) [WIP] redesign App Argument model. - [`834b2df`](https://github.com/1Remote/1Remote/commit/834b2df114d102b74c317e90297d657ffdd38ec5) [WIP] redesign App Argument model. - [`7667391`](https://github.com/1Remote/1Remote/commit/7667391b5fad0b132ec64cef5bae24723b3b773c) [WIP] new App view first edition(not done yet) - [`44c36ef`](https://github.com/1Remote/1Remote/commit/44c36ef5180d248b76d5085565b8280f2d8081c4) [WIP] new App add selections - [`00dd995`](https://github.com/1Remote/1Remote/commit/00dd9954145270685627310af0e12a7a1e568bed) [WIP] Editor for app arguments - [`e455766`](https://github.com/1Remote/1Remote/commit/e4557667058934a6002540e26ccfb54e365971f3) [WIP] Editor for app arguments - [`4f43f3d`](https://github.com/1Remote/1Remote/commit/4f43f3d2531cc88e90667b44972c419381cb9dad) [WIP] app arguments edit & refacing - [`2beb103`](https://github.com/1Remote/1Remote/commit/2beb103d2d8648a7320d98e1d819c1eaa4efc97a) [WIP] app argument's Selections change to Dictionary, add preset configurations for kitty - [`86d7ca2`](https://github.com/1Remote/1Remote/commit/86d7ca270c635eafdcd0c9bbf60719b488d5b446) [WIP] app argument supports arguments with no blank(fro winscp cli) ### 📊 Changes **88 files changed** (+3563 additions, -515 deletions) <details> <summary>View changed files</summary> 📝 `Shawn.Utils` (+1 -1) 📝 `Ui/Controls/AutoCompleteComboBox.xaml.cs` (+1 -1) 📝 `Ui/Controls/LogoSelector.xaml.cs` (+1 -1) 📝 `Ui/Controls/PasswordInput.xaml` (+5 -5) 📝 `Ui/Controls/PasswordInput.xaml.cs` (+3 -2) 📝 `Ui/Ioc.cs` (+23 -2) 📝 `Ui/Model/GlobalData.cs` (+28 -23) ➕ `Ui/Model/Protocol/AppArgument.cs` (+396 -0) ➕ `Ui/Model/Protocol/AppArgumentHelper.cs` (+541 -0) ➕ `Ui/Model/Protocol/AppProtocol.cs` (+179 -0) 📝 `Ui/Model/Protocol/Base/Credential.cs` (+8 -5) 📝 `Ui/Model/Protocol/Base/ProtocolBase.cs` (+21 -6) 📝 `Ui/Model/Protocol/Base/ProtocolBaseWithAddressPort.cs` (+21 -3) 📝 `Ui/Model/Protocol/Base/ProtocolBaseWithAddressPortUserPwd.cs` (+38 -3) ➖ `Ui/Model/Protocol/LocalApp.cs` (+0 -179) 📝 `Ui/Model/Protocol/SFTP.cs` (+15 -9) 📝 `Ui/Model/Protocol/SSH.cs` (+17 -9) 📝 `Ui/Model/Protocol/Vnc.cs` (+15 -0) 📝 `Ui/Model/ProtocolActionHelper.cs` (+10 -10) 📝 `Ui/Model/TagActionHelper.cs` (+9 -9) _...and 68 more files_ </details> ### 📄 Description remake the app protocol --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-28 12:06:55 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/1Remote#1840

No description provided.

Rows
Columns