[PR #544] [MERGED] Branch dev #1839

Closed
opened 2026-02-28 12:06:55 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/1Remote/1Remote/pull/544
Author: @VShawn
Created: 10/29/2023
Status: Merged
Merged: 10/29/2023
Merged by: @VShawn

Base: mainHead: Branch_dev


📝 Commits (6)

📊 Changes

59 files changed (+967 additions, -776 deletions)

View changed files

📝 .github/workflows/build-on-dev-push.yml (+52 -52)
📝 Shawn.Utils (+1 -1)
📝 Ui/Controls/AutoCompleteComboBox.xaml (+1 -0)
📝 Ui/Model/Protocol/AppProtocol.cs (+27 -6)
📝 Ui/Model/Protocol/Base/ProtocolBase.cs (+30 -10)
📝 Ui/Model/Protocol/Base/ProtocolBaseWithAddressPort.cs (+37 -0)
📝 Ui/Model/Protocol/RdpApp.cs (+31 -1)
📝 Ui/Model/Protocol/Serial.cs (+33 -0)
📝 Ui/Ui.csproj (+10 -10)
📝 Ui/View/AboutPageView.xaml (+3 -0)
📝 Ui/View/AboutPageViewModel.cs (+1 -0)
Ui/View/Editor/FormBase.cs (+0 -40)
📝 Ui/View/Editor/Forms/AlternativeCredential/AlternativeCredentialEditView.xaml (+4 -7)
Ui/View/Editor/Forms/AlternativeCredential/AlternativeCredentialListControl.xaml.cs (+0 -28)
📝 Ui/View/Editor/Forms/AlternativeCredential/AlternativeCredentialListView.xaml (+8 -7)
Ui/View/Editor/Forms/AlternativeCredential/AlternativeCredentialListViewModel.cs (+13 -0)
Ui/View/Editor/Forms/AppFormView.xaml.cs (+0 -50)
📝 Ui/View/Editor/Forms/Argument/ArgumentEditViewModel.cs (+2 -2)
📝 Ui/View/Editor/Forms/Argument/ArgumentListControl.xaml (+22 -7)
Ui/View/Editor/Forms/BaseFormWithAddressPort.xaml (+0 -36)

...and 39 more files

📄 Description

refactor:

  1. Validation for editor and tooltip

  2. protocol editor to mvvm

  3. some fix of app protocol


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/1Remote/1Remote/pull/544 **Author:** [@VShawn](https://github.com/VShawn) **Created:** 10/29/2023 **Status:** ✅ Merged **Merged:** 10/29/2023 **Merged by:** [@VShawn](https://github.com/VShawn) **Base:** `main` ← **Head:** `Branch_dev` --- ### 📝 Commits (6) - [`32c360e`](https://github.com/1Remote/1Remote/commit/32c360e963b8648693f1eb9e2e6135f6227f8393) chore: remove net48 build from GitHub action. - [`1d6e4a2`](https://github.com/1Remote/1Remote/commit/1d6e4a25610c56d1cd29c47049c6d8e18c17dc7a) [WIP] refacing protocol editor view to MVVM - [`cbab802`](https://github.com/1Remote/1Remote/commit/cbab802a31c4f57745e29715797e2c30662d6ae6) Merge branch 'Branch_dev' of https://github.com/1Remote/1Remote into Branch_dev - [`a127b63`](https://github.com/1Remote/1Remote/commit/a127b63d2ab6f9e31dfb9fde73fda8199713c093) Merge branch 'main' into Branch_dev - [`bfe6372`](https://github.com/1Remote/1Remote/commit/bfe63725da86a15b2ee2e88c737f69aeb16dd0ab) [WIP] refacing protocol editor view constructor - [`e0bf7a6`](https://github.com/1Remote/1Remote/commit/e0bf7a6ce3c0cae744412c2a7fc916b8063990ef) refactor: 1. Validation for editor and tooltip ### 📊 Changes **59 files changed** (+967 additions, -776 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build-on-dev-push.yml` (+52 -52) 📝 `Shawn.Utils` (+1 -1) 📝 `Ui/Controls/AutoCompleteComboBox.xaml` (+1 -0) 📝 `Ui/Model/Protocol/AppProtocol.cs` (+27 -6) 📝 `Ui/Model/Protocol/Base/ProtocolBase.cs` (+30 -10) 📝 `Ui/Model/Protocol/Base/ProtocolBaseWithAddressPort.cs` (+37 -0) 📝 `Ui/Model/Protocol/RdpApp.cs` (+31 -1) 📝 `Ui/Model/Protocol/Serial.cs` (+33 -0) 📝 `Ui/Ui.csproj` (+10 -10) 📝 `Ui/View/AboutPageView.xaml` (+3 -0) 📝 `Ui/View/AboutPageViewModel.cs` (+1 -0) ➖ `Ui/View/Editor/FormBase.cs` (+0 -40) 📝 `Ui/View/Editor/Forms/AlternativeCredential/AlternativeCredentialEditView.xaml` (+4 -7) ➖ `Ui/View/Editor/Forms/AlternativeCredential/AlternativeCredentialListControl.xaml.cs` (+0 -28) 📝 `Ui/View/Editor/Forms/AlternativeCredential/AlternativeCredentialListView.xaml` (+8 -7) ➕ `Ui/View/Editor/Forms/AlternativeCredential/AlternativeCredentialListViewModel.cs` (+13 -0) ➖ `Ui/View/Editor/Forms/AppFormView.xaml.cs` (+0 -50) 📝 `Ui/View/Editor/Forms/Argument/ArgumentEditViewModel.cs` (+2 -2) 📝 `Ui/View/Editor/Forms/Argument/ArgumentListControl.xaml` (+22 -7) ➖ `Ui/View/Editor/Forms/BaseFormWithAddressPort.xaml` (+0 -36) _...and 39 more files_ </details> ### 📄 Description refactor: 1. Validation for editor and tooltip 2. protocol editor to mvvm 3. some fix of app protocol --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 12:06:55 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/1Remote#1839
No description provided.