starred/1Remote

Fork 0

mirror of https://github.com/1Remote/1Remote.git synced 2026-04-25 13:36:03 +03:00

[GH-ISSUE #1066] Unable to close/resize the integrated exe(such as PuTTY) after #1057 #1796

New issue

Open

opened 2026-02-28 12:06:42 +03:00 by kerem · 3 comments

kerem commented

2026-02-28 12:06:42 +03:00

Owner

Originally created by @VShawn on GitHub (Feb 5, 2026).
Original GitHub issue: https://github.com/1Remote/1Remote/issues/1066

Originally assigned to: @VShawn on GitHub.

Describe the bug

https://github.com/user-attachments/assets/7ea640d4-d008-47e0-b9ed-10a0962f6d82

To Reproduce
Steps to reproduce the behavior:

Open ssh session
Click close button once (Not close and log shows: TabWindowView: Vm?.SelectedItem?.Content?.FocusOnMe())

The bug appeared after the modification at #1057 in the RunForIntegrate() function.

Originally created by @VShawn on GitHub (Feb 5, 2026). Original GitHub issue: https://github.com/1Remote/1Remote/issues/1066 Originally assigned to: @VShawn on GitHub. **Describe the bug** https://github.com/user-attachments/assets/7ea640d4-d008-47e0-b9ed-10a0962f6d82 **To Reproduce** Steps to reproduce the behavior: 1. Open ssh session 2. Click close button once (Not close and log shows: TabWindowView: Vm?.SelectedItem?.Content?.FocusOnMe()) The bug appeared after the modification at #1057 in the RunForIntegrate() function.

kerem added the

bug

label

2026-02-28 12:06:42 +03:00

kerem commented

2026-02-28 12:06:42 +03:00

Author

Owner

@VShawn commented on GitHub (Feb 5, 2026):

https://github.com/1Remote/1Remote/blob/main/Ui/View/Host/TabWindowView.xaml_timer.cs#L102-L121

In the #1057, the condition System.Windows.Forms.Control.MouseButtons != MouseButtons.Left was removed, which caused this bug.

This is my fault because in the code comments I only mentioned that missing this condition would prevent the tab from moving, but I didn’t warn that it would also cause issues with the close button and resize functionality.

@itagagaki, may I ask if restoring this condition now would cause any problems with the features you submitted?

@VShawn commented on GitHub (Feb 5, 2026): https://github.com/1Remote/1Remote/blob/main/Ui/View/Host/TabWindowView.xaml_timer.cs#L102-L121 In the #1057, the condition `System.Windows.Forms.Control.MouseButtons != MouseButtons.Left` was removed, which caused this bug. This is my fault because in the code comments I only mentioned that missing this condition would prevent the tab from moving, but I didn’t warn that it would also cause issues with the close button and resize functionality. @itagagaki, may I ask if restoring this condition now would cause any problems with the features you submitted?

kerem commented

2026-02-28 12:06:42 +03:00

Author

Owner

@itagagaki commented on GitHub (Feb 5, 2026):

The focus issue has been resolved by removing that condition. Therefore, if we reinstate it, the problem will recur.

However, I don't think the patch was the best solution to the problem. Even after applying it, I've noticed that another issue remains unresolved: in some situations, the mouse pointer may not be displayed in the RDP window.

I'll make time to look into this further.

@itagagaki commented on GitHub (Feb 5, 2026): The focus issue has been resolved by removing that condition. Therefore, if we reinstate it, the problem will recur. However, I don't think the patch was the best solution to the problem. Even after applying it, I've noticed that another issue remains unresolved: in some situations, the mouse pointer may not be displayed in the RDP window. I'll make time to look into this further.

kerem commented

2026-02-28 12:06:42 +03:00

Author

Owner

@VShawn commented on GitHub (Feb 6, 2026):

@itagagaki Okey, I see. But I would like to mention that I believe the SSH can not closing issue is more serious than the focus, so for now, I’ve reinstated the condition temporarily. Plz dont forget this temporarily trifle when you continue your research :)

p.s. It may be possible to add another judgment condition: check what the current mouse click target is. If it’s a tab button, then setting focus would be allowed. This would resolve issue 1052 as well as the current bug.

@VShawn commented on GitHub (Feb 6, 2026): @itagagaki Okey, I see. But I would like to mention that I believe the `SSH can not closing issue` is more serious than the `focus`, so for now, I’ve reinstated the condition temporarily. Plz dont forget this temporarily trifle when you continue your research :) p.s. It may be possible to add another judgment condition: `check what the current mouse click target is`. If it’s a tab button, then setting focus would be allowed. This would resolve issue 1052 as well as the current bug.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/1Remote#1796

No description provided.

Rows
Columns