mirror of
https://github.com/1Remote/1Remote.git
synced 2026-04-25 13:36:03 +03:00
[GH-ISSUE #930] RDP disconnect may causes freeze #1715
Labels
No labels
area-configuration
area-ct-app
area-ct-rdp
area-ct-remoteapp
area-ct-ssh
area-ct-vnc
area-launcher
area-list
area-tags
area-teamwork
bug
chore
dependencies
general-build/ci
general-performance
general-refactor
general-security
general-supportive
general-ux
meta-documentation
meta-enhancement
meta-enhancement
meta-feature
meta-help-wanted
meta-unknown-error
priority-hi
priority-low
pull-request
question
resolution-duplicate
resolution-invalid
resolution-wontfix
stale
task-put-off
task-still-considering
task-working-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/1Remote#1715
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @itagagaki on GitHub (May 12, 2025).
Original GitHub issue: https://github.com/1Remote/1Remote/issues/930
Originally assigned to: @VShawn on GitHub.
Reproducibility is random.
This did not happen with
EnableAutoReconnect:i:0, but it may be a coincidence.@VShawn commented on GitHub (May 12, 2025):
there is no evidence to support this.
@itagagaki commented on GitHub (May 12, 2025):
I think you've said similar things before, but I don't understand why you think that.
@itagagaki commented on GitHub (May 12, 2025):
Happened in this case as well.
@itagagaki commented on GitHub (May 12, 2025):
This issue blocks #878
@VShawn commented on GitHub (May 13, 2025):
It's also possible that this issue is related to
switching to NET9. After the switch, I received a lot of feedback about programs freezing on the MS STORE, so I have now rolled back MS STORE to the old version.@VShawn commented on GitHub (May 14, 2025):
Perhaps it is related to the update of the AxMSTSCLib.dll dynamic library? Should I consider rolling it back?
The thought is If this issue has been occurring frequently since 1.2.0, it is likely related to the update in version 1.2.0, and the major change in version 1.2.0 for RDP is the update of the dll.
@itagagaki commented on GitHub (May 14, 2025):
The change in AxMSTSCLib.dll does not seem to be relevant.
The phenomena occurring are as follows:
My guess is that the connection between the session and the window or tab is broken during reconnection and destrosys resources or objects that should not be destroyed.
@VShawn commented on GitHub (May 15, 2025):
Well, it seems a bit different from what I thought. The reproduction logic is quite complex, kudos to you for being able to find it out.
then the crucial point lies on the auto reconnect logic, I considering a complete overhaul of this module.
@itagagaki commented on GitHub (May 15, 2025):
I hope my fixes will help with that.
https://github.com/itagagaki/1Remote/tree/fix-rdp-reconnection
@VShawn commented on GitHub (May 17, 2025):
sorry, I've been quite busy with work these days and haven't had time to check GitHub.
May I ask if I can merge your branch directly, or would you prefer me to make modifications based on your work?
I have reviewed your code and it seems fine. However, 1Remote now may missing a button to cancel the reconnection for the user.
@itagagaki commented on GitHub (May 17, 2025):
My branch above fixes #878
However, this bug has not yet been resolved, so it should not be merged.
I mentioned the branch to you because I think the code is necessary for analyzing this bug.
If you can fix this bug, then you can merge directly or I can submit a PR.
I will investigate this bug further, but I am busy too, so I don't know which of us will finish first.
The "Dismiss" button appears and works during the reconnect process.
@VShawn commented on GitHub (May 20, 2025):
After conducting several tests over the past few days, I have not encountered any freezing issues. It seems that my environment does not trigger this problem. Now I decided to halt my investigation into this matter until there are any new discoveries.
Here are the steps of my testing:
@github-actions[bot] commented on GitHub (Jun 20, 2025):
This issue is stale because it has been open for 30 days with no activity.
@github-actions[bot] commented on GitHub (Jul 4, 2025):
This issue was closed because it has been inactive for 14 days since being marked as stale.