mirror of
https://github.com/1Remote/1Remote.git
synced 2026-04-25 13:36:03 +03:00
[GH-ISSUE #804] Resolve environment variables present in connection options #1612
Labels
No labels
area-configuration
area-ct-app
area-ct-rdp
area-ct-remoteapp
area-ct-ssh
area-ct-vnc
area-launcher
area-list
area-tags
area-teamwork
bug
chore
dependencies
general-build/ci
general-performance
general-refactor
general-security
general-supportive
general-ux
meta-documentation
meta-enhancement
meta-enhancement
meta-feature
meta-help-wanted
meta-unknown-error
priority-hi
priority-low
pull-request
question
resolution-duplicate
resolution-invalid
resolution-wontfix
stale
task-put-off
task-still-considering
task-working-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/1Remote#1612
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @argonym on GitHub (Dec 9, 2024).
Original GitHub issue: https://github.com/1Remote/1Remote/issues/804
Originally assigned to: @VShawn on GitHub.
Use case:
As a team, we intend to share the list of (RDP) connections by using the same database.
But when connecting to a server, everyone needs to connect with a different username.
The username can be obtained from a (user-specific) Windows environment variable.
Feature request:
When connecting, resolve environment variables in the "User" connection option.
Probably also in other options where it might make sense.
And for each option where this is possible, provide a hint that this is possible. E.g. in the tooltip for the input field.
@majkinetor commented on GitHub (Dec 9, 2024):
All that is suboptimal. Ideally, 1RM should allow for having local settings of remote database.
I discussed that here: https://github.com/1Remote/1Remote/discussions/414 and the very thing you asked is noted there:
@majkinetor commented on GitHub (Dec 9, 2024):
Note that we didn't mention environment vars there, as IMO this is very unsecure. Such method is typically used on CI/CD platforms and that use case seems valid (although also highly controversial), but keeping multiple passwords as env var is both non secure, no portable etc.
Maybe
.envfile would be an option, with 1RM moving it into its own space, that way at least they won't be visible by typing 1 command in shell. However, I would prefer complete solution (modying any connection setting locally, not just username/pass).@VShawn commented on GitHub (Dec 10, 2024):
environment variables to store personal accounts is an immature solution, #414 is clearly better(Of course the workload is also greater). My previous plan was to create a
customized information tablein sqlite database (allowing customized data except server name, icon, hostname and port). due to time constraints, I was unable to start this work.Using environment variable-based accounts can be attempted as workaround in the development branch for those who need the feature right now, but I do not recommend merging it into the main branch.
@github-actions[bot] commented on GitHub (Jan 9, 2025):
This issue is stale because it has been open for 30 days with no activity.
@github-actions[bot] commented on GitHub (Jan 24, 2025):
This issue was closed because it has been inactive for 14 days since being marked as stale.