mirror of
https://github.com/1Remote/1Remote.git
synced 2026-04-25 13:36:03 +03:00
[GH-ISSUE #792] Incorrect messages for problems opening database #1607
Labels
No labels
area-configuration
area-ct-app
area-ct-rdp
area-ct-remoteapp
area-ct-ssh
area-ct-vnc
area-launcher
area-list
area-tags
area-teamwork
bug
chore
dependencies
general-build/ci
general-performance
general-refactor
general-security
general-supportive
general-ux
meta-documentation
meta-enhancement
meta-enhancement
meta-feature
meta-help-wanted
meta-unknown-error
priority-hi
priority-low
pull-request
question
resolution-duplicate
resolution-invalid
resolution-wontfix
stale
task-put-off
task-still-considering
task-working-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/1Remote#1607
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @itagagaki on GitHub (Nov 30, 2024).
Original GitHub issue: https://github.com/1Remote/1Remote/issues/792
Originally assigned to: @VShawn on GitHub.
If the database does not provide write permission, I believe the message key
string_database_error_permission_denied(row 108 in glossary.csv) would be used. However, the message text in each language corresponding to this key seems to say “no read permission” or something similar.It may also be necessary to check if this key is used in other cases other than no write permission.
Also recheck row 107 (
system_options_data_security_error_can_not_open).@VShawn commented on GitHub (Dec 1, 2024):
You are right, it would be better to change
string_database_error_permission_deniedto "no read or write permission" and similar.Additionally
system_options_data_security_error_can_not_openhas been deprecated, which was previously used as the prompt when an encrypted SQLite database was opened with a wrong password. This sentence will only be useful if database encryption feature is added back in the future. https://github.com/1Remote/1Remote/issues/755@VShawn commented on GitHub (Dec 21, 2024):
i confirmed here is the only reference of
string_database_error_permission_deniedhttps://github.com/1Remote/1Remote/blob/main/Ui/View/Settings/DataSource/SqliteSettingViewModel.cs#L111-L115