[GH-ISSUE #792] Incorrect messages for problems opening database #1607

Closed
opened 2026-02-28 12:05:33 +03:00 by kerem · 2 comments
Owner

Originally created by @itagagaki on GitHub (Nov 30, 2024).
Original GitHub issue: https://github.com/1Remote/1Remote/issues/792

Originally assigned to: @VShawn on GitHub.

If the database does not provide write permission, I believe the message key string_database_error_permission_denied (row 108 in glossary.csv) would be used. However, the message text in each language corresponding to this key seems to say “no read permission” or something similar.

It may also be necessary to check if this key is used in other cases other than no write permission.

Also recheck row 107 (system_options_data_security_error_can_not_open).

Originally created by @itagagaki on GitHub (Nov 30, 2024). Original GitHub issue: https://github.com/1Remote/1Remote/issues/792 Originally assigned to: @VShawn on GitHub. If the database does not provide write permission, I believe the message key `string_database_error_permission_denied` (row 108 in glossary.csv) would be used. However, the message text in each language corresponding to this key seems to say “no read permission” or something similar. It may also be necessary to check if this key is used in other cases other than no write permission. Also recheck row 107 (`system_options_data_security_error_can_not_open`).
kerem 2026-02-28 12:05:33 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@VShawn commented on GitHub (Dec 1, 2024):

You are right, it would be better to change string_database_error_permission_denied to "no read or write permission" and similar.

Additionally system_options_data_security_error_can_not_open has been deprecated, which was previously used as the prompt when an encrypted SQLite database was opened with a wrong password. This sentence will only be useful if database encryption feature is added back in the future. https://github.com/1Remote/1Remote/issues/755

<!-- gh-comment-id:2509531456 --> @VShawn commented on GitHub (Dec 1, 2024): You are right, it would be better to change `string_database_error_permission_denied` to "no read or write permission" and similar. Additionally `system_options_data_security_error_can_not_open` has been deprecated, which was previously used as the prompt when an encrypted SQLite database was opened with a wrong password. This sentence will only be useful if database encryption feature is added back in the future. https://github.com/1Remote/1Remote/issues/755
Author
Owner

@VShawn commented on GitHub (Dec 21, 2024):

i confirmed here is the only reference of string_database_error_permission_denied

https://github.com/1Remote/1Remote/blob/main/Ui/View/Settings/DataSource/SqliteSettingViewModel.cs#L111-L115

<!-- gh-comment-id:2557966622 --> @VShawn commented on GitHub (Dec 21, 2024): i confirmed here is the only reference of `string_database_error_permission_denied` https://github.com/1Remote/1Remote/blob/main/Ui/View/Settings/DataSource/SqliteSettingViewModel.cs#L111-L115
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/1Remote#1607
No description provided.