mirror of
https://github.com/1Remote/1Remote.git
synced 2026-04-25 05:26:04 +03:00
[GH-ISSUE #401] Redesign of the tags UX #1302
Labels
No labels
area-configuration
area-ct-app
area-ct-rdp
area-ct-remoteapp
area-ct-ssh
area-ct-vnc
area-launcher
area-list
area-tags
area-teamwork
bug
chore
dependencies
general-build/ci
general-performance
general-refactor
general-security
general-supportive
general-ux
meta-documentation
meta-enhancement
meta-enhancement
meta-feature
meta-help-wanted
meta-unknown-error
priority-hi
priority-low
pull-request
question
resolution-duplicate
resolution-invalid
resolution-wontfix
stale
task-put-off
task-still-considering
task-working-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/1Remote#1302
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @majkinetor on GitHub (May 7, 2023).
Original GitHub issue: https://github.com/1Remote/1Remote/issues/401
Originally assigned to: @VShawn on GitHub.
Tags UX is needlessly large and non responsive:
details
Tags UX should be completelly redesigned.
Tasks
Tag details with middle click1. Tag description (to be shown in a tooltip)2. Tag hotkey?@majkinetor commented on GitHub (May 8, 2023):
BTW, this tag list not showing in columns is something that apperaed in 1.0.beta3, in 0.4 it was not like that.
@majkinetor commented on GitHub (May 8, 2023):
Actually, I dont know what I was thinking when I sad that clicking on tag could be used as a checkbox, as clicking on tag is used to activate that tag. But nevertheless, this is simple to change, we could add "pin tag" in context menu which doesn't spoil the UX as pinning is not that frequent operation.
Regarding number of columns, I think they should just be listed horizontally as much as it can be filled with current screen, there is no need to artificially introduce columns as you may have short and long tags. They could be sorted by name (like now) or frequency. This should be very easy to implement and maintain and it will be responsive relative to the screen size.
@majkinetor commented on GitHub (May 8, 2023):
Mockup:
@majkinetor commented on GitHub (May 8, 2023):
Not sure if we need group by database... or even limiting view by having combo with database selection.
@VShawn commented on GitHub (May 9, 2023):
new users may not know there's a right click menu for pin.
@majkinetor commented on GitHub (May 9, 2023):
If that is your worry, we can add a message 😃
@majkinetor commented on GitHub (May 16, 2023):
@VShawn can you quickly fix regression in latest 2 versions? Tag list is unusable now.
Unless you already started working on this then I will wait :)
@VShawn commented on GitHub (May 17, 2023):
I won't working on this befor #409 is closed.
I working on #395, and then #409, and then this one :)
@majkinetor commented on GitHub (May 17, 2023):
OK, that will take time then. Can you fix this quickly becuase I can't pin antyhing without too much stress any more :)
EDIT: Ah, ignore, I just realized I was stupid and scrolling horizontaly instead of using search 🙄
@VShawn commented on GitHub (May 18, 2023):
The tag description seems not not to be very necessary, but the cost of it is high.
For example, it requires designing a new tag table (the current tag only stores a string in connection json), and handling data synchronization of the tag table when add \ del \ rename tags, and resolving situations where there are tags with the same name but different descriptions in two databases.
Therefore, please reconsider this. If it must be done, please create a new ticket specifically for it.
And case insensitivity is rude. You should not decide for the user that they cannot use "ab" after using "AB". AFAIK green is color while Green is a name.
@majkinetor commented on GitHub (May 18, 2023):
OK, tag table is natural thing to have, I didn't think you would just put tags in connections. Lets skip it.
Almost no tag system I know is case sensitive. There is nothing rude about it, its expected, especially on Windows where file names are not case sensitive. If that is so, then activation (and also # search) has a bug - if I click tag name, i should see that exact tag name, not all the variants like now:
That makes no sense and if not having case is rude, then this is maximum rude.
@VShawn commented on GitHub (May 18, 2023):
Yes there is a problem within tag search because when I developing this feature, I wanted to enable fuzzy searching while also supporting case sensitivity.... no better solution was found.
and please consider another situation: there is a tag "abcd" in db1 and a tag "Abcd" in db2. Should we merge these two tags if the it is not case sensitive? And when displaying the tag, should it be displayed as "abcd" or "Abcd"?
I have considered case sensitivity when building the tag system from the beginning, but these 2 still bother me now. I have thought about convert all tags to lowercase, but as mentioned sometimes capitalization can change the meaning of a word.
@majkinetor commented on GitHub (May 18, 2023):
What I do in my projects is lowercase them. Nobody ever complained.
As an example from the wild, Diigo which has tags as basic mechanism (you can't really use it without it, so you have hundreeds of them) lowercases them in the tag list and autocomplete, but keeps user input as it is:
Search shows lower case variants always
Its listed as it is input on the bookmark
All tags are listed lowercase in the tag list
So you could go that way, its IMO good UX as tags are listed as input on most important place and the one that you see most often - the objects having them (connections in this case).
So to recap:
So tags are case insensitive during operations but shown with exact case that user set on individual connections.
@majkinetor commented on GitHub (May 24, 2023):
@VShawn, It would be good to consistently allow for context menu, not only in tags:
@VShawn commented on GitHub (May 24, 2023):
Yeap I woring on this now, since the 'right click ed' hijacked the mouse right click event, i need to refact this part to make context menu work
@majkinetor commented on GitHub (May 25, 2023):
In latest nightly some tags do not work. Clicking them on the main list does nothing, but they can be selected from the Tags tab.
You change the case of tags on editing connection (sometimes)
Different case in bulk edit is not recognized as same tag (maybe it shouldn't though)
@VShawn commented on GitHub (May 25, 2023):
The logic has become confusing, I am considering converting all tags to lowercase.
@majkinetor commented on GitHub (May 25, 2023):
Its not worth complicating, so it should be done.