mirror of
https://github.com/1Remote/1Remote.git
synced 2026-04-25 13:36:03 +03:00
[GH-ISSUE #293] Protocol app can't be run from the PATH #1214
Labels
No labels
area-configuration
area-ct-app
area-ct-rdp
area-ct-remoteapp
area-ct-ssh
area-ct-vnc
area-launcher
area-list
area-tags
area-teamwork
bug
chore
dependencies
general-build/ci
general-performance
general-refactor
general-security
general-supportive
general-ux
meta-documentation
meta-enhancement
meta-enhancement
meta-feature
meta-help-wanted
meta-unknown-error
priority-hi
priority-low
pull-request
question
resolution-duplicate
resolution-invalid
resolution-wontfix
stale
task-put-off
task-still-considering
task-working-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/1Remote#1214
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @majkinetor on GitHub (Sep 26, 2022).
Original GitHub issue: https://github.com/1Remote/1Remote/issues/293
Originally assigned to: @VShawn on GitHub.
Is your enhancement related to a problem? Please describe.
I have wfreerdp.exe on the PATH. I still have to specify full PATH to it in PRM options.
Describe the solution you'd like
If it is on the PATH it should run just by the name. This can be used to integrate it with less config with other tools.
Additional context
The chocolatey
binfolder is on the PATH:BTW, since latest release of PRM, wfreerdp is not embedded as connection tab, in previous it was (the same version of wfreerdp).
@majkinetor commented on GitHub (Sep 27, 2022):
Env vars could be supported to for portability reasons.
@VShawn commented on GitHub (Sep 29, 2022):
Reading paths from environment variables was never considered before.
I make this feature now:
PRemoteM.0.7.1.7.beta.2-x64.zip
@majkinetor commented on GitHub (Sep 29, 2022):
That doesnt seem to work:
You implemented usage of env vars, such as:
%ChocolateyInstall%\bin\wfreerdp.exeand%FOO%\bar.exeand in both cases it doesn't work, and doesn't even report exe missing - i just get blank black screen.Also, since I have
%ChocolateyInstall%\binon thePATHenv. var, it should work without any path.So we have 2 features here:
PATHenv var@majkinetor commented on GitHub (Sep 29, 2022):
Second thing is way more important, as it allows one to install arbitrary protocols and PRM will just be able to work with them:
cinst premotem vnc winspc wfreerdp ....Then Premotem can even come with predefined protocols that will just work if the app is somewhere on the system.
@VShawn commented on GitHub (Sep 30, 2022):
IT WORKS ON ME.
How your PATH be like? Maybe the path format will affect PRM reading.
@VShawn commented on GitHub (Sep 30, 2022):
test the path with
%BlabLA%\bioworks too
@majkinetor commented on GitHub (Oct 2, 2022):
Using path in
PATHenv varPATH
wfreerdp
Protocol
Connection
Result: popup
:Setting path using env var inside it
I also tried to use
ChocolateyInstallenv var inside wfreerdp path:wfreerdp
Connection
Result: black screen
@VShawn commented on GitHub (Oct 5, 2022):
Ahh, I tested it on
APPprotocol, no test on the runner, let me check the runner path after I back home from vacation.@VShawn commented on GitHub (Oct 13, 2022):
A bug was found in external runner path checker which make PATH not work.
PRemoteM.0.7.1.7.beta.3-x64.zip
@majkinetor commented on GitHub (Oct 13, 2022):
First case now works, second case still doesn't.
@VShawn commented on GitHub (Oct 13, 2022):
second case is chocolatey case? I don't have a chocolatey installed, maybe test it later.
@majkinetor commented on GitHub (Oct 13, 2022):
No, I just used choco as an example:
For example try
%SystemRoot%\notepad.exe@VShawn commented on GitHub (Oct 13, 2022):
Ahhh I see, you means using the environment variable in path directly.
@majkinetor commented on GitHub (Oct 13, 2022):
Yeah, things like that are needed for portability. If you carry your PRM with you (or copy it to another system), and it relies on tools on the local system, for it to work you generaly need to use env vars to avoid possible path changes on each system.
@majkinetor commented on GitHub (Oct 13, 2022):
This will especially be useful in multiuser scneario with relational db holding data.
@VShawn commented on GitHub (Oct 13, 2022):
goal, tested with winscp :)
PRemoteM.0.7.1.7.beta.3-x64.zip
@majkinetor commented on GitHub (Oct 13, 2022):
Works now.
@VShawn commented on GitHub (Oct 13, 2022):
god damn GFW, I can not push to github now.
fatal: Could not read from remote repository.@majkinetor commented on GitHub (Oct 13, 2022):
Probably temporary