mirror of
https://github.com/1Remote/1Remote.git
synced 2026-04-25 13:36:03 +03:00
[GH-ISSUE #237] Latency in list when filtering in launcher #1168
Labels
No labels
area-configuration
area-ct-app
area-ct-rdp
area-ct-remoteapp
area-ct-ssh
area-ct-vnc
area-launcher
area-list
area-tags
area-teamwork
bug
chore
dependencies
general-build/ci
general-performance
general-refactor
general-security
general-supportive
general-ux
meta-documentation
meta-enhancement
meta-enhancement
meta-feature
meta-help-wanted
meta-unknown-error
priority-hi
priority-low
pull-request
question
resolution-duplicate
resolution-invalid
resolution-wontfix
stale
task-put-off
task-still-considering
task-working-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/1Remote#1168
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @majkinetor on GitHub (May 14, 2022).
Original GitHub issue: https://github.com/1Remote/1Remote/issues/237
Originally assigned to: @VShawn on GitHub.
Describe the bug
When you type something in launcher, you can clearly see that list filters itself out in multiple steps, as items are fast disappearing. List should update ASAP without such glitches.
I see that you didn't use debounce (didn't check code but its obvious).
@VShawn commented on GitHub (May 16, 2022):
can give screenshot? I did not find this latency
@majkinetor commented on GitHub (May 16, 2022):
Its not that pronounced, you need to have lots of connections too and some CPU hog:
Maybe I exaggerate, its mildly irritating, not 100% fluid. Notice that filtering occurs ~500ms after all letters have been typed, which is observable. Humans notice anything longer then 300ms. This should be IMO faster, why would filtering 50 items I have on this system be glitchy ? With more it gets worst.
Details
@VShawn commented on GitHub (May 16, 2022):
BTW my vault has 36 items
besides my debounce strategic is crude
https://github.com/VShawn/PRemoteM/blob/dev/PRemoteM/View/LauncherWindowViewModel.cs#L87-L106
@majkinetor commented on GitHub (May 16, 2022):
I think that is too low. Perhaps 300ms would be more OK.
https://ux.stackexchange.com/questions/95336/how-long-should-the-debounce-timeout-be
@VShawn commented on GitHub (May 16, 2022):
I've tried 300ms, not snappy anymore.
@majkinetor commented on GitHub (May 16, 2022):
Mhm... OK. let it be then.