starred/1Remote

Fork 0

mirror of https://github.com/1Remote/1Remote.git synced 2026-04-25 13:36:03 +03:00

[GH-ISSUE #209] Protocol runner for WinScp is not ebedded #1141

New issue

Closed

opened 2026-02-28 12:02:19 +03:00 by kerem · 4 comments

kerem commented

2026-02-28 12:02:19 +03:00

Owner

Originally created by @majkinetor on GitHub (Feb 26, 2022).
Original GitHub issue: https://github.com/1Remote/1Remote/issues/209

Originally assigned to: @VShawn on GitHub.

Describe the bug

When I start WinSCP custom connection added as SFTP protocol runner, its shown in its own window. This is not a big deal but it is inconsistent and some features do not apply like background color of the frame.

Expected behavior

To be shown among other connection tabs.

Screenshot

Originally created by @majkinetor on GitHub (Feb 26, 2022). Original GitHub issue: https://github.com/1Remote/1Remote/issues/209 Originally assigned to: @VShawn on GitHub. **Describe the bug** When I start WinSCP custom connection added as SFTP protocol runner, its shown in its own window. This is not a big deal but it is inconsistent and some features do not apply like background color of the frame. **Expected behavior** To be shown among other connection tabs. **Screenshot** ![image](https://user-images.githubusercontent.com/85767/155860214-1f39fb80-00ff-4fb4-a39e-5da907b04618.png)

kerem

2026-02-28 12:02:19 +03:00

closed this issue
added the
bug
label

kerem commented

2026-02-28 12:02:20 +03:00

Author

Owner

@VShawn commented on GitHub (Feb 27, 2022):

hum....sometime I just can not capture the handle of the external app window, and I can't move it into my tab window without that handle.

Even with the same external app, it is possible that it works on one machine but not works on another machine.

I did not find a solution now, that's why I provide this:

@VShawn commented on GitHub (Feb 27, 2022): hum....sometime I just can not capture the handle of the external app window, and I can't move it into my tab window without that handle. Even with the same external app, it is possible that it works on one machine but not works on another machine. I did not find a solution now, that's why I provide this: ![image](https://user-images.githubusercontent.com/10143738/155864754-6b1e2775-49c3-464b-899b-ab175ab94a38.png)

kerem commented

2026-02-28 12:02:20 +03:00

Author

Owner

@majkinetor commented on GitHub (Feb 28, 2022):

This was disabled. When I enabled it, it was still outside but tab appeared.

sometime I just can not capture the handle of the external app window, and I can't move it into my tab window without that handle.

OK, when I find time I will inspect more about this...

@majkinetor commented on GitHub (Feb 28, 2022): This was disabled. When I enabled it, it was still outside but tab appeared. > sometime I just can not capture the handle of the external app window, and I can't move it into my tab window without that handle. OK, when I find time I will inspect more about this...

kerem commented

2026-02-28 12:02:20 +03:00

Author

Owner

@VShawn commented on GitHub (Mar 1, 2022):

Yes sometimes it works, sometimes it fault when enabled Hosting.

Here is my two consecutive sessions:

@VShawn commented on GitHub (Mar 1, 2022): Yes sometimes it works, sometimes it fault when enabled `Hosting`. Here is my two consecutive sessions: ![image](https://user-images.githubusercontent.com/10143738/156100593-1e207fc7-7131-4c11-8c11-14323b3bc50c.png)

kerem commented

2026-02-28 12:02:20 +03:00

Author

Owner

@VShawn commented on GitHub (Mar 2, 2022):

After some inspect.

In ticke #192, I remove the loop detect for the external app's WindowHandle to reduce cpu usage.
After this change, PRM can not get the real WindowHandle of WinSCP (because WindowHandle of WinSCP will change after it connected).

@VShawn commented on GitHub (Mar 2, 2022): After some inspect. In ticke #192, I remove the loop detect for the external app's WindowHandle to reduce cpu usage. After this change, PRM can not get the real WindowHandle of WinSCP (because WindowHandle of WinSCP will change after it connected).

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/1Remote#1141

No description provided.

Rows
Columns